Page MenuHomeFreeBSD
Differential D13937

Don't hardcode /usr/bin as the path for mktemp in build tools
ClosedPublic
Actions

Authored by arichardson on Jan 16 2018, 7:35 PM.
Tags
None
Referenced Files
F103020556: D13937.id38943.diff
Tue, Nov 19, 10:14 PM
F103011675: D13937.diff
Tue, Nov 19, 7:38 PM
Unknown Object (File)
Oct 18 2024, 5:38 PM
Unknown Object (File)
Oct 2 2024, 10:34 AM
Unknown Object (File)
Oct 1 2024, 5:18 AM
Unknown Object (File)
Sep 30 2024, 2:51 PM
Unknown Object (File)
Sep 27 2024, 11:08 AM
Unknown Object (File)
Sep 25 2024, 3:10 AM
View All 50 Files
Subscribers
bdrewery
imp

Details

Reviewers
jhb
emaste
jilles
bdrewery
Commits
rS328934: Don't hardcode /usr/bin as the path for mktemp in build tools
Summary

It won't work e.g. when crossbuilding from Ubuntu Linux as mktemp is in
/bin there.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

arichardson created this revision.Jan 16 2018, 7:35 PM
Herald added a reviewer: jilles. · View Herald TranscriptJan 16 2018, 7:35 PM
Harbormaster completed remote builds in B14419: Diff 38050.Jan 16 2018, 7:35 PM
emaste added a subscriber: bdrewery.Jan 16 2018, 8:23 PM

This reverts rS88450, but the commit message there unfortunately states exactly what was done but not why.

bdrewery accepted this revision.Jan 24 2018, 8:33 PM
This revision is now accepted and ready to land.Jan 24 2018, 8:33 PM
emaste added a comment.Jan 24 2018, 8:42 PM

No objection from me.

jhb added a comment.Jan 30 2018, 12:03 AM

Ok by me (with my mentor hat)

Closed by commit rS328934: Don't hardcode /usr/bin as the path for mktemp in build tools (authored by arichardson). · Explain WhyFeb 6 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 6 2018, 3:41 PM

Revision Contents
Changeset List

PathSize
head/
2 lines
bin/
sh/
2 lines
2 lines

Diff 38943

View Options

head/Makefile.inc1

Loading...
View Options

head/bin/sh/mkbuiltins

Loading...
View Options

head/bin/sh/mktokens

Loading...