Page MenuHomeFreeBSD
Differential D12836

ctl: Make max_luns and max_ports tunable variables instead of hardcoded defines.
ClosedPublic
Actions

Authored by manu on Oct 30 2017, 3:45 PM.
Tags
None
Referenced Files
F110691087: D12836.diff
Fri, Feb 21, 11:06 PM
Unknown Object (File)
Mon, Feb 17, 1:22 PM
Unknown Object (File)
Sun, Feb 16, 8:33 PM
Unknown Object (File)
Sun, Feb 16, 7:41 PM
Unknown Object (File)
Sat, Feb 15, 7:48 PM
Unknown Object (File)
Sat, Feb 1, 12:27 AM
Unknown Object (File)
Sun, Jan 26, 4:08 AM
Unknown Object (File)
Jan 18 2025, 8:04 AM
View All 99 Files
Subscribers
bcr
bjk
imp
wblock

Details

Reviewers
bapt
trasz
bcr
Group Reviewers
manpages
Commits
rS326091: MFC r325517, r325554
rS325517: ctl: Make max_luns and max_ports tunable variables instead of hardcoded
Summary

Sponsored-By: Gandi.net
MFC-After: 2 weeks

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12307
Build 12596: arc lint + arc unit

Event Timeline

manu created this revision.Oct 30 2017, 3:45 PM
Herald added a reviewer: manpages. · View Herald TranscriptOct 30 2017, 3:45 PM
Herald added a subscriber: imp. · View Herald Transcript
manu updated this revision to Diff 34459.Oct 30 2017, 4:05 PM

Bump .Dd

bcr accepted this revision.Oct 30 2017, 8:31 PM
bcr added a subscriber: bcr.

OK from manpages.

This revision is now accepted and ready to land.Oct 30 2017, 8:31 PM
bapt accepted this revision.Nov 3 2017, 12:13 PM
trasz added inline comments.Nov 3 2017, 12:47 PM
sys/cam/ctl/ctl.c
422

Could you add read-only (CTL_RDTUN) sysctl-s for these two, to make it possible to easily check the current values?

1896

Could you reword it to indicate what the valid value would be?

manu added inline comments.Nov 3 2017, 12:51 PM
sys/cam/ctl/ctl.c
422

Yeah sure I'll do that.

1896

Will do.

manu updated this revision to Diff 34850.Nov 6 2017, 10:25 AM

Address trasz@ comments.

This revision now requires review to proceed.Nov 6 2017, 10:25 AM
manu marked 4 inline comments as done.Nov 6 2017, 10:26 AM
trasz accepted this revision.Nov 6 2017, 6:01 PM
This revision is now accepted and ready to land.Nov 6 2017, 6:01 PM
manu updated this revision to Diff 34871.Nov 7 2017, 10:18 AM

Fix compilation when CTL_LEGACY_STATS is defined.

This revision now requires review to proceed.Nov 7 2017, 10:18 AM
Harbormaster completed remote builds in B12512: Diff 34850.Nov 7 2017, 3:51 PM
Harbormaster completed remote builds in B12526: Diff 34871.
Closed by commit rS325517: ctl: Make max_luns and max_ports tunable variables instead of hardcoded (authored by manu). · Explain WhyNov 7 2017, 5:08 PM
This revision was automatically updated to reflect the committed changes.
bjk added a subscriber: bjk.Nov 7 2017, 11:05 PM
bjk added inline comments.
head/share/man/man4/ctl.4
202 ↗(On Diff #34886)

mdoc style is to start a new line after a sentence-ending full stop. So, something like

Specifies the maximum number of ports supported, which must be a power of 2.
The default value is 256

(similarly for line 200.)

wblock added a subscriber: wblock.Nov 18 2017, 5:09 PM

Please remember to update .Dd on commit. Thanks!

head/share/man/man4/ctl.4
195 ↗(On Diff #34886)

s/The following/These/

200 ↗(On Diff #34886)

"Specifies the" doesn't add anything and makes the reader search farther in the sentence for what this actually is.

Maximum number of LUNs supported.
Must be a power of 2.  Default 1024.
202 ↗(On Diff #34886)

As above:

Maximum number of ports supported.
Must be a power of 2. Default 256.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
11 lines
sys/
cam/
ctl/
129 lines
17 lines
14 lines

Diff 34459

View Options

share/man/man4/ctl.4

Loading...
View Options

sys/cam/ctl/ctl.c

Loading...
View Options

sys/cam/ctl/ctl_ioctl.h

Loading...
View Options

sys/cam/ctl/ctl_private.h

Loading...