Page MenuHomeFreeBSD

Don't complain about missing mountpoints for scripted installations.
ClosedPublic

Authored by rpokala on Sep 12 2017, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 7:31 AM
Unknown Object (File)
Sep 29 2024, 5:58 AM
Unknown Object (File)
Sep 22 2024, 5:39 AM
Unknown Object (File)
Sep 15 2024, 7:24 AM
Unknown Object (File)
Sep 5 2024, 9:12 AM
Unknown Object (File)
Sep 2 2024, 2:19 AM
Unknown Object (File)
Aug 24 2024, 3:17 AM
Unknown Object (File)
Aug 8 2024, 9:18 PM

Details

Summary

Don't bother with an interactive prompt for scripted installs; assume the person who wrote the script knew what they were doing, and proceed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11530
Build 11884: arc lint + arc unit

Event Timeline

dteske added inline comments.
usr.sbin/bsdinstall/partedit/gpart_ops.c
1055–1056

"choice = 0;" can be moved above the "if (interactive) {" line to eliminate the need for an "} else {" (improves readability imho)

Address dteske's comment by unconditionally setting "choice", and overriding it
for the interactive case.

This revision is now accepted and ready to land.Sep 12 2017, 9:59 PM
This revision was automatically updated to reflect the committed changes.