Fix test timeout: common.dtraceUtil.t_dtrace_contrib.tst_DestructWithFunction_d_ksh
ClosedPublic
Actions

Authored by lwhsu on Jul 20 2017, 6:08 PM.

Details

Reviewers

gnn
markj
ngie

Commits

rS321466: Add an auxiliary subroutine to generate read(2) event while testing.

Summary

This test timeout on a quiet system because there is nobody triggers read probefunc while test execution.

Add a delay-executed cat command to generate some noise

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/dtraceUtil && kyua debug t_dtrace_contrib:tst.DestructWithFunction.d.ksh

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 10591
Build 10997: arc lint + arc unit

Event Timeline

lwhsu created this revision.Jul 20 2017, 6:08 PM

Herald added 1 blocking reviewer(s): gnn. · View Herald TranscriptJul 20 2017, 6:08 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B10591: Diff 31018.Jul 20 2017, 6:08 PM

It might be a good idea to increase the sleep time in the backgrounded process to avoid clock skew, but this should work. Thanks!!

In D11673#241834, @ngie wrote:

It might be a good idea to increase the sleep time in the backgrounded process to avoid clock skew, but this should work. Thanks!!

In the long run I would modify dtest (test suite driver) to enable execute some post-actions.

Another thought is converting this test case to tst.DestructWithFunction.d and tst.DestructWithFunction.d.exe, to prevent race condition.

In D11673#242536, @lwhsu wrote:

Another thought is converting this test case to tst.DestructWithFunction.d and tst.DestructWithFunction.d.exe, to prevent race condition.

Or just kill the shell process from within the script. There are many dtrace tests that do this.

Use a subprocess to execute auxiliary program and recycle it after test

Harbormaster completed remote builds in B10638: Diff 31126.Jul 24 2017, 10:30 AM

ngie requested changes to this revision.Jul 24 2017, 5:21 PM

ngie added inline comments.

cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
45	Could you please add a `sleep 0.1` here to avoid burning CPU too badly? Both FreeBSD and Solaris's version of sleep(1) support floating point precision.