HomeFreeBSD

MFC r332101:

Description

MFC r332101:

pf: Improve ioctl validation for DIOCRADDTABLES and DIOCRDELTABLES

The DIOCRADDTABLES and DIOCRDELTABLES ioctls can process a number of
tables at a time, and as such try to allocate <number of tables> *
sizeof(struct pfr_table). This multiplication can overflow. Thanks to
mallocarray() this is not exploitable, but an overflow does panic the
system.

Arbitrarily limit this to 65535 tables. pfctl only ever processes one
table at a time, so it presents no issues there.

Details

Provenance
kpAuthored on
Parents
rS332485: Remove .info debugging output that accidentally got left in for MFC commit.
Branches
Unknown
Tags
Unknown