HomeFreeBSD

Fix range locking in ZIL commit codepath

Description

Fix range locking in ZIL commit codepath

Since OpenZFS 7578 (1b7c1e5) if we have a ZVOL with logbias=throughput
we will force WR_INDIRECT itxs in zvol_log_write() setting itx->itx_lr
offset and length to the offset and length of the BIO from
zvol_write()->zvol_log_write(): these offset and length are later used
to take a range lock in zillog->zl_get_data function: zvol_get_data().

Now suppose we have a ZVOL with blocksize=8K and push 4K writes to
offset 0: we will only be range-locking 0-4096. This means the
ASSERTion we make in dbuf_unoverride() is no longer valid because now
dmu_sync() is called from zilog's get_data functions holding a partial
lock on the dbuf.

Fix this by taking a range lock on the whole block in zvol_get_data().

Reviewed-by: Chunwei Chen <tuxoko@gmail.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #6238
Closes #6315
Closes #6356
Closes #6477

Details

Provenance
LOLi <loli10K@users.noreply.github.com>Authored on Aug 21 2017, 3:59 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Aug 21 2017, 3:59 PM
Parents
rG08de8c16f5d3: Fix remounting snapshots read-write
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGf763c3d1df56: Fix range locking in ZIL commit codepath (authored by LOLi <loli10K@users.noreply.github.com>).Aug 21 2017, 3:59 PM