Diffusion FreeBSD src repository f5d78bea1f69

sifive_spi: Add missing case for SPIBUS_MODE_NONE
f5d78bea1f69
Actions

Description

sifive_spi: Add missing case for SPIBUS_MODE_NONE

Otherwise sckmode is left uninitialised, not zero. This mode is used for
the on-board flash on the HiFive Unmatched board. Whilst here, catch
unknown modes and return an error rather than silently continuing.

Reviewed by: riscv, jrtc27
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D31562

Details

Provenance

skibo	Authored on Aug 30 2021, 8:39 PM
jrtc27	Committed on Aug 30 2021, 10:38 PM

Reviewer

riscv

Differential Revision

D31562: Add support for spi flash on SiFive Unmatched.

Parents

rG64f09f234665: cxgbei: Limit T5 transmit data segments to 15k.

Branches

Unknown

Tags

Unknown

Event Timeline

jrtc27 committed rGf5d78bea1f69: sifive_spi: Add missing case for SPIBUS_MODE_NONE (authored by skibo).Aug 30 2021, 10:38 PM

jrtc27 added an edge: D31562: Add support for spi flash on SiFive Unmatched..

jrtc27 mentioned this in rGc108f304472e: sifive_spi: Add missing case for SPIBUS_MODE_NONE.Sep 7 2021, 12:12 PM

Changes (1)

Path

Size

sys/

riscv/

sifive/

sifive_spi.c

rGf5d78bea1f69

View Options

sys/riscv/sifive/sifive_spi.c