Diffusion FreeBSD src repository f4ceaff56dda

bhyve: add config option to modify LPC IDs
f4ceaff56dda
Actions

Description

bhyve: add config option to modify LPC IDs

The Intel GOP driver checks the LPC IDs to detect the platform it's
running on. The GOP driver only works on the platforms it's written for.
Maybe other Intel driver have the same behaviour. For that reason, we
should use the LPC IDs of the FreeBSD host for GPU passthrough to work
properly.

We don't know if setting different LPC IDs have any side effect.
Therefore, don't use the host LPC IDs by default on Intel system. Give
the user the opportunity to modify the LPC IDs.

Reviewed by: jhb
MFC after: 1 week
Sponsored by: Beckhoff Automation GmbH & Co. KG
Differential Revision: https://reviews.freebsd.org/D28280

Details

Provenance

corvink

Authored on Nov 23 2021, 12:14 PM

Reviewer

jhb

Differential Revision

D28280: bhyve: add config option to modify lpc ids

Parents

rGb72e06b13ee0: bhyve: make use of helper to read PCI IDs from bhyve config

Branches

Unknown

Tags

Unknown

Event Timeline

corvink committed rGf4ceaff56dda: bhyve: add config option to modify LPC IDs (authored by corvink).Mar 27 2023, 8:10 AM

corvink added an edge: D28280: bhyve: add config option to modify lpc ids.

corvink mentioned this in D39310: bhyve: scan PCI device functions to find host LPC.Mar 29 2023, 9:32 AM

corvink mentioned this in rGc98d13fbf9c9: bhyve: fix spelling mistake of pcireg option.Mar 29 2023, 9:34 AM

corvink mentioned this in rGd3e03d235e31: bhyve: scan PCI device functions to find host LPC.Mar 31 2023, 6:04 AM

andy_omniosce.org added a subscriber: andy_omniosce.org.Apr 4 2023, 1:26 PM

andy_omniosce.org added inline comments.

/usr.sbin/bhyve/pci_lpc.c
502	This change means that if the host system does not have an LPC, then the guest will not have one either. Was that intentional? I run bhyve on at least one host system which does not have an LPC.