HomeFreeBSD

vm_phys_add_seg(): Check for bad segments, allow empty ones

Description

vm_phys_add_seg(): Check for bad segments, allow empty ones

A bad specification is if 'start' is strictly greater than 'end', or
bounds are not page aligned.

The latter was already tested under INVARIANTS, but now will be also on
production kernels. The reason is that vm_phys_early_startup() pours
early segments into the final phys_segs[] array via vm_phys_add_seg(),
but vm_phys_early_add_seg() did not check their validity. Checking
segments once and for all in vm_phys_add_seg() avoids duplicating
validity tests and is possible since early segments are not used before
being poured into phys_segs[]. Finally, vm_phys_add_seg() is not
performance critical.

Allow empty segments and discard them (silently, unless 'bootverbose' is
true), as vm_page_startup() was testing for this case before calling
vm_phys_add_seg(), and we felt the same test in vm_phys_early_startup()
was due before calling vm_phys_add_seg(). As a consequence, remove the
empty segment test from vm_page_startup().

Reviewed by: markj
MFC after: 1 week
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D48627

Details

Provenance
olceAuthored on Oct 9 2024, 5:04 PM
Reviewer
markj
Differential Revision
D48627: vm_phys_add_seg(): Check for bad segments, allow empty ones
Parents
rG125ef4e041fe: vm_phys_avail_check(): Check index parity, fix panic messages
Branches
Unknown
Tags
Unknown