HomeFreeBSD

Fix false ENOENT on snapshot control dentries

Description

Fix false ENOENT on snapshot control dentries

Lookups in the snapshot control directory for an existing snapshot
fail with ENOENT if an earlier lookup failed before the snapshot was
created. This is because the earlier lookup causes a negative dentry
to be cached which is never invalidated.

The bug can be reproduced as follows (the second ls should succeed):

$ ls /tank/.zfs/snapshot/s
ls: cannot access /tank/.zfs/snapshot/s: No such file or directory
$ zfs snap tank@s
$ ls /tank/.zfs/snapshot/s
ls: cannot access /tank/.zfs/snapshot/s: No such file or directory

To remedy this, always invalidate cached dentries in the snapshot
control directory. Since these entries never exist on disk there is
no significant performance penalty for the extra lookups.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1192

Details

Provenance
Ned Bass <bass6@llnl.gov>Authored on Jan 14 2013, 9:59 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jan 17 2013, 12:28 AM
Parents
rG94a9bb470911: Fix quoting error in unmount command
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGf1a05fa11484: Fix false ENOENT on snapshot control dentries (authored by Ned Bass <bass6@llnl.gov>).Jan 17 2013, 12:28 AM