HomeFreeBSD

Fix ZED auto-replace for VDEVs using by-id paths

Description

Fix ZED auto-replace for VDEVs using by-id paths

The change is simple -- restore the original code so that the VDEV
path is updated when using by-id paths. The more challenging part
was to devise a second ZTS test, that would test auto-replace for
'by-id' and help prevent a future regression.

With that new test, we can now do an A|B test with , and without,
the fix to confirm that auto-replace for by-id paths works. The
existing auto-replace test, functional/fault/auto_replace_001_pos,
will confirm that we didn't break auto-replace for 'by-vdev' paths.

In the original functional/fault/auto_replace_001_pos test, the disk
wipe (using dd) was not effective in removing the partitioning since
the kernel was never informed of the wipe.

Added a call to wipefs(8) so that the kernel is informed and ZED will
re-partition the device.

Added a validation step that the re-partitioning occurred by
confirming that the GPT partition UUID changes.

Sponsored-By: OpenDrives Inc.
Sponsored-By: Klara Inc.
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Signed-off-by: Don Brady <don.brady@klarasystems.com>
Closes #15363

Details

Provenance
Don Brady <don.brady@delphix.com>Authored on Oct 20 2023, 4:29 PM
GitHub <noreply@github.com>Committed on Oct 20 2023, 4:29 PM
Parents
rGc0e58995e334: Large sync writes perform worse with slog
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGf0f330e1212e: Fix ZED auto-replace for VDEVs using by-id paths (authored by Don Brady <don.brady@delphix.com>).Oct 20 2023, 4:29 PM