HomeFreeBSD

Remove pool io kstats

Description

Remove pool io kstats

This mostly reverts "3537 want pool io kstats" commit of 8 years ago.

From one side this code using pool-wide locks became pretty bad for
performance, creating significant lock contention in I/O pipeline.
From another, there are more efficient ways now to obtain detailed
statistics, while this statistics is illumos-specific and much less
usable on Linux and FreeBSD, reported only via procfs/sysctls.

This commit does not remove KSTAT_TYPE_IO implementation, that may
be removed later together with already unused KSTAT_TYPE_INTR and
KSTAT_TYPE_TIMER.

Reviewed-by: Matthew Ahrens <mahrens@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Sponsored-By: iXsystems, Inc.
Closes #12212

Details

Provenance
mavAuthored on Jun 10 2021, 3:27 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jun 10 2021, 5:50 PM
Parents
rG2e158b0e0b0b: Added error for writing to /dev/ on Linux
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGefdfb14fc8c9: Remove pool io kstats (authored by mav).Jun 10 2021, 5:50 PM