HomeFreeBSD

Fix ZVOL BLKFLSBUF ioctl

Description

Fix ZVOL BLKFLSBUF ioctl

The BLKFLSBUF ioctl is expected to do two things:

  • flush dirty pages to stable storage, and
  • invalidate clean pages

Unfortunately, the existing implementation of BLKFLSBUF in
zvol_ioctl() only flushes pages which are part of the current
TXG to disk. There may be additional dirty pages in the
page cache which haven't yet been submitted to the DMU and
therefore aren't part of any TXG.

Furthermore because zvol_ioctl() returns 0 the generic
blkdev_flushbuf() does not invalidate the page cache.

Resolve the issue by moving bdev_flush() in to zvol_ioctl()
and explicitly waiting for a full TXG sync. Then invalidate
the page cache. The associated ARC buffers need not be
evicted since they cannot be bypassed using O_DIRECT.

Reviewed-by: Chunwei Chen <david.chen@osnexus.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #5871
Closes #5879

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Mar 10 2017, 1:43 AM
GitHub <noreply@github.com>Committed on Mar 10 2017, 1:43 AM
Parents
rG589bb918ef39: Suppress cppcheck nullPointer error in zfs_write
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGef1bdf363c02: Fix ZVOL BLKFLSBUF ioctl (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Mar 10 2017, 1:43 AM