HomeFreeBSD

arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset.

Description

arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset.

This variable was flagged as a set but unused warning as its value was
read from a register and then modified to set a bit
(TI_MBOX_SYSCONFIG_SOFTRST). After the variable is modified, the code
then loops waiting for the SOFTRST bit to go clear in the
TI_MBOX_SYSCONFIG register. Presumably merely reading from the
register does not request a reset as other places in the driver read
this register, so most likely the updated value of sysconfig setting
the reset bit is supposed to be written to the register to request a
reset before the polling loop that waits for the reset to finish.

Reviewed by: emaste
Differential Revision: https://reviews.freebsd.org/D34856

Details

Provenance
jhbAuthored on Apr 18 2022, 9:09 PM
Reviewer
emaste
Differential Revision
D34856: arm ti_mbox_attach: Write sysconfig to TI_MBOX_SYSCONFIG to request reset.
Parents
rGc2f6aae0076d: machine/in_cksum.h: don't include sys/cdefs.h
Branches
Unknown
Tags
Unknown