HomeFreeBSD

e1000: Delay safe_pause switch until SI_SUB_CLOCKS

Description

e1000: Delay safe_pause switch until SI_SUB_CLOCKS

Based on sysinit_sub_id, SI_SUB_CLOCKS is after SI_SUB_CONFIGURE.

SI_SUB_CONFIGURE  = 0x3800000,  /* Configure devices */  
At this stage, the variable “cold” will be set to 0.

SI_SUB_CLOCKS    = 0x4800000,  /* real-time and stat clocks*/
At this stage, the clock configuration will be done, and the real-time
clock can be used.

In the e1000 driver, if the API safe_pause_* are called between
SI_SUB_CONFIGURE and SI_SUB_CLOCKS stages, it will choose the wrong
clock source. The API safe_pause_* uses “cold” the value of which is
updated in SI_SUB_CONFIGURE, to decide if the real-time clock source is
ready. However, the real-time clock is not ready til the SI_SUB_CLOCKS
routines are done.

Obtained from: Juniper Networks
Differential Revision: https://reviews.freebsd.org/D42920

(cherry picked from commit 930a1e6f3d2dd629774f1b48b1acf7ba482ab659)

Details

Provenance
joyul_juniper.netAuthored on Sep 25 2024, 9:19 AM
Kevin Bowling <kbowling@FreeBSD.org>Committed on Oct 2 2024, 7:52 PM
Differential Revision
D42920: Fix clock source in the API safe_pause_*() in e1000 driver
Parents
rG262f8dd6143e: e1000: Add sysctl for igb(4) DMA Coalesce
Branches
Unknown
Tags
Unknown