HomeFreeBSD

Use native inode->i_nlink instead of znode->z_links

Description

Use native inode->i_nlink instead of znode->z_links

A mostly mechanical change, taking into account i_nlink is 32 bits vs ZFS's
64 bit on-disk link count.

We revert "xattr dir doesn't get purged during iput" (ddae16a) as this is a
more Linux-integrated fix for the same issue.

In addition, setting the initial link count on a new node has been changed
from setting one less than required in zfs_mknode() then incrementing to the
correct count in zfs_link_create() (which was somewhat bizarre in the first
place), to setting the correct count in zfs_mknode() and not incrementing it
in zfs_link_create(). This both means we no longer set the link count in
sa_bulk_update() twice (once for the initial incorrect count then again for
the correct count), as well as adhering to the Linux requirement of not
incrementing a zero link count without I_LINKABLE (see linux commit
f4e0c30c).

Signed-off-by: Chris Dunlop <chris@onthe.net.au>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@osnexus.com>
Closes #4838
Issue #227

Details

Provenance
Chris Dunlop <chris@onthe.net.au>Authored on Jul 14 2016, 2:44 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jul 14 2016, 11:25 PM
Parents
rG02de3e3c5d54: Fix dbuf_stats_hash_table_data race
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGdfbc86309fd8: Use native inode->i_nlink instead of znode->z_links (authored by Chris Dunlop <chris@onthe.net.au>).Jul 14 2016, 11:25 PM