HomeFreeBSD

Fix up CXXSTD support originally added in r345708

Description

Fix up CXXSTD support originally added in r345708

r345708 worked for the base system, but unfortunately, caused a lot of
disruption for third-party packages that relied on C++, since bsd.sys.mk is
used by applications outside the base system. The defaults picked didn't match
the compiler's defaults and broke some builds that didn't specify a standard,
as well as some that overrode the value by setting -std=gnu++14 (for
example) manually.

This change takes a more relaxed approach to appending -std=${CXXSTD} to
CXXFLAGS, by only doing so when the value is specified, as opposed to
overriding the standard set by an end-user. This avoids the need for having
to bake NOP default into bsd.sys.mk for supported compiler-toolchain
versions.

In order to make this change possible, add CXXSTD to Makefile snippets which
relied on the default value (c++11) added in r345708.

MFC after: 2 weeks
MFC with: r345708, r346574
Reviewed by: emaste
Reported by: jbeich
Differential Revision: https://reviews.freebsd.org/D19895 (as part of a larger change)

Details

Provenance
ngieAuthored on Apr 22 2019, 6:40 PM
Parents
rG59a05bdf354d: Create boot_img as a global variable
Branches
Unknown
Tags
Unknown

Event Timeline