HomeFreeBSD

Use _Noreturn (C11; GNU89) properly

Description

Use _Noreturn (C11; GNU89) properly

A function that returns with no value is a different thing from a
function that doesn't return at all. Those are two orthogonal
concepts, commonly confused.

pthread_create(3) expects a pointer to a start routine that has a
very precise prototype:

    void *(*start_routine)(void *);

However, other thread functions, such as kernel ones, expect:

    void (*start_routine)(void *);

Providing a different one is incorrect, and has only been working
because the ABIs happen to produce a compatible function.

We should use '_Noreturn void', since it's the natural type, and
then provide a '_Noreturn void *' wrapper for pthread functions.

For consistency, replace most cases of NORETURN or
attribute__((noreturn)) by _Noreturn. _Noreturn is understood
by -std=gnu89, so it should be safe to use everywhere.

Ref: https://github.com/openzfs/zfs/pull/13110#discussion_r808450136
Ref: https://software.codidact.com/posts/285972
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Ahelenia ZiemiaƄska <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Closes #13120

Details

Provenance
Alejandro Colomar <Colomar.6.4.3@GMail.com>Authored on Mar 5 2022, 12:25 AM
GitHub <noreply@github.com>Committed on Mar 5 2022, 12:25 AM
Parents
rG06b805067833: zpool: main: list: don't pay for printf
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rGdb7f1a91def6: Use _Noreturn (C11; GNU89) properly (authored by Alejandro Colomar <Colomar.6.4.3@GMail.com>).Mar 5 2022, 12:25 AM