HomeFreeBSD

ocs_fc: Fix CAM status reporting in ocs_fc(4) when no data is returned.

Description

ocs_fc: Fix CAM status reporting in ocs_fc(4) when no data is returned.

In ocs_scsi_initiator_io_cb(), if the SCSI command that is
getting completed had a residual equal to the transfer length,
it was setting the CCB status to CAM_REQ_CMP.

That breaks the expected behavior for commands like READ ATTRIBUTE.
For READ ATTRIBUTE, if the first attribute requested doesn't exist,
the command is supposed to return an error (Illegal Request,
Invalid Field in CDB).  The broken behavior for READ ATTRIBUTE
caused LTFS tape formatting to fail.  It looks for attribute
0x1623, and expects to see an error if the attribute isn't present.

In addition, if the residual is negative (indicating an overrun),
only set the CCB status to CAM_DATA_RUN_ERR if we have not already
reported an error.  The SCSI sense data will have more detail about
what went wrong.

sys/dev/ocs_fc/ocs_cam.c:
        In ocs_scsi_initiator_io_cb(), don't set the status to
        CAM_REQ_CMP if the residual is equal to the transfer length.

        Also, only set CAM_DATA_RUN_ERR if we didn't get SCSI
        status.

Submitted by: ken@kdm.org
Reviewed by: mav, ken

(cherry picked from commit 1af49c2eeb4a05f524ed9a6657c741bc96fbaf87)

Details

Event Timeline

Ram Kishore Vegesna <ram@FreeBSD.org> committed rGd55873846cfc: ocs_fc: Fix CAM status reporting in ocs_fc(4) when no data is returned. (authored by Ram Kishore Vegesna <ram@FreeBSD.org>).Dec 17 2021, 9:57 AM