HomeFreeBSD

LinuxKPI: 802.11: sync sta->addr in lkpi_iv_update_bss()

Description

LinuxKPI: 802.11: sync sta->addr in lkpi_iv_update_bss()

In lkpi_iv_update_bss() introduced in d9f59799fc3e7 we swap lsta and
along with that sta and drv state if ni gets reused and swapped under
us by net80211. What we did not do was to sync sta->addr which later
(usually in lkpi_sta_assoc_to_run) during a bss_info update cause
problems in drivers (or firmware) as the BSSID and the station address
were not aligned.

If this proves to hold up to fix iwlwifi issues seem on firmware
for older chipsets, multi-assoc runs, and rtw89 (which this fixes)
we should add asserts that lkpi_iv_update_bss() can only happen in
pre-auth stages and/or make sure we factor out synching more state
fields.

Found debugging: rtw89

(cherry picked from commit ed3ef56b29fd194a5ac0b820fd09bf01a4922bb7)

Details

Provenance
bzAuthored on Jun 26 2022, 7:04 PM
Parents
rG07bec0d40e07: net80211 / LinuxKPI: 802.11: add Control Trigger Subframe information
Branches
Unknown
Tags
Unknown