HomeFreeBSD

crypto_get_ptrs() should always write to *out_data_2

Description

crypto_get_ptrs() should always write to *out_data_2

Callers will check if it has been set to NULL before trying to access
it, but never initialize it themselves. Whenever "one block spans two
iovecs", crypto_get_ptrs() will return, without ever setting
*out_data_2 = NULL. The caller will then do a NULL check against the
uninitailized pointer and if it is not zero, pass it to memcpy().

The only reason this has not caused horrible runtime issues is because
memcpy() should be told to copy zero bytes when this happens. That
said, this is technically undefined behavior, so we should correct it so
that future changes to the code cannot trigger it.

Clang's static analyzer found this with the help of CodeChecker's CTU
analysis.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14043

Details

Provenance
Richard Yao <richard.yao@alumni.stonybrook.edu>Authored on Oct 16 2022, 3:35 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Oct 20 2022, 12:10 AM
Parents
rG44f71818f82c: Silence static analyzer warnings about spa_sync_props()
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGc77d2d741571: crypto_get_ptrs() should always write to *out_data_2 (authored by Richard Yao <richard.yao@alumni.stonybrook.edu>).Oct 20 2022, 12:10 AM