HomeFreeBSD

Fix "zpool add -n" for dedup, special and log devices

Description

Fix "zpool add -n" for dedup, special and log devices

For dedup, special and log devices "zpool add -n" does not print
correctly their vdev type:

~# zpool add -n pool dedup /tmp/dedup special /tmp/special log /tmp/log
would update 'pool' to the following configuration:
pool

	  /tmp/normal
	  /tmp/dedup
	  /tmp/special
	  /tmp/log

This could lead storage administrators to modify their ZFS pools to
unexpected and unintended vdev configurations.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: loli10K <ezomori.nozomu@gmail.com>
Closes #9783
Closes #9390

Details

Provenance
loli10K <ezomori.nozomu@gmail.com>Authored on Jan 6 2020, 11:40 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jan 6 2020, 11:40 PM
Parents
rGbc9cef11fddf: Fix QAT allocation failure return value
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rGc24fa4b19a1b: Fix "zpool add -n" for dedup, special and log devices (authored by loli10K <ezomori.nozomu@gmail.com>).Jan 6 2020, 11:40 PM