HomeFreeBSD

With the sync from Dragonfly BSD in r318216 a bug slipped in (also still present

Description

With the sync from Dragonfly BSD in r318216 a bug slipped in (also still present
upstream it seems).

The tlv variable was changed to a pointer but the advancement of the data pointer
was left as sizeof(tlv). While the sizeof the (now) pointer equals the
sizeof 2 x uint32_t (size of the struct) on 64bit platforms, on 32bit platforms
the size of the advancement of the data pointer was wrong leading to
firmware load issues.

Correctly advance the data pointer by the size of the structure and not by
the size of a pointer.

PR: 219683
Submitted by: waddlesplash gamil.com (Haiku) on irc
MFC after: 1 week

Details

Provenance
bzAuthored on Jan 15 2019, 10:31 PM
Parents
rG89ec2f414ca2: [drm] Fix off-by-one error when accessing driver-specific ioctl handlers array
Branches
Unknown
Tags
Unknown

Event Timeline