HomeFreeBSD

wpa_supplicant/hostapd: Fix uninitialized packet pointer on error

Description

wpa_supplicant/hostapd: Fix uninitialized packet pointer on error

The packet pointer (called packet) will remain uninitialized when
pcap_next_ex() returns an error. This occurs when the wlan
interface is shut down using ifconfig destroy. Adding a NULL
assignment to packet duplicates what pcap_next() does.

The reason we use pcap_next_ex() in this instance is because with
pacp_next() when we receive a null pointer if there was an error
or if no packets were read. With pcap_next_ex() we can differentiate
between an error and legitimately no packets were received.

PR: 270649
Reported by: Robert Morris <rtm@lcs.mit.edu>
Fixes: 6e5d01124fd4
MFC after: 3 days

Details

Provenance
cyAuthored on Apr 6 2023, 4:07 AM
Parents
rG5cb402cc89c0: llvm-objcopy: link man page as strip.1 when WITH_LLVM_BINUTILS is set
Branches
Unknown
Tags
Unknown