HomeFreeBSD

Fix zdb -R decompression

Description

Fix zdb -R decompression

There are some issues in the zdb -R decompression implementation.

The first is that ZLE can easily decompress non-ZLE streams. So we add
ZDB_NO_ZLE env to make zdb skip ZLE.

The second is the random bytes appended to pabd, pbuf2 stuff. This serve
no purpose at all, those bytes shouldn't be read during decompression
anyway. Instead, we randomize lbuf2, so that we can make sure
decompression fill exactly to lsize by bcmp lbuf and lbuf2.

The last one is the condition to detect fail is wrong.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: loli10K <ezomori.nozomu@gmail.com>
Signed-off-by: Chunwei Chen <david.chen@nutanix.com>
Closes #7099
Closes #4984

Details

Provenance
Chunwei Chen <david.chen@nutanix.com>Authored on Feb 2 2018, 12:19 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Feb 9 2018, 6:11 PM
Parents
rG0c0b0ad48add: Fix racy assignment of zcb.zcb_haderrors
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG950e17c215be: Fix zdb -R decompression (authored by Chunwei Chen <david.chen@nutanix.com>).Feb 9 2018, 6:11 PM