HomeFreeBSD

Replace zpool_events_next() "block" parm w/ "flags"

Description

Replace zpool_events_next() "block" parm w/ "flags"

zpool_events_next() can be called in blocking mode by specifying a
non-zero value for the "block" parameter. However, the design of
the ZFS Event Daemon (zed) requires additional functionality from
zpool_events_next(). Instead of adding additional arguments to the
function, it makes more sense to use flags that can be bitwise-or'd
together.

This commit replaces the zpool_events_next() int "block" parameter with
an unsigned bitwise "flags" parameter. It also defines ZEVENT_NONE
to specify the default behavior. Since non-blocking mode can be
specified with the existing ZEVENT_NONBLOCK flag, the default behavior
becomes blocking mode. This, in effect, inverts the previous use
of the "block" parameter. Existing callers of zpool_events_next()
have been modified to check for the ZEVENT_NONBLOCK flag.

Signed-off-by: Chris Dunlap <cdunlap@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #2

Details

Provenance
Chris Dunlap <cdunlap@llnl.gov>Authored on Feb 12 2014, 6:30 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Mar 31 2014, 11:11 PM
Parents
rG07917db99085: Add defs for makefile installation dir vars
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG8c7aa0cfc475: Replace zpool_events_next() "block" parm w/ "flags" (authored by Chris Dunlap <cdunlap@llnl.gov>).Mar 31 2014, 11:11 PM