HomeFreeBSD

Add -c to zpool iostat & status to run command

Description

Add -c to zpool iostat & status to run command

This patch adds a command (-c) option to zpool status and zpool iostat. The
-c option allows you to run an arbitrary command on each vdev and display
the first line of output in zpool status/iostat. The environment vars
VDEV_PATH and VDEV_UPATH are set to the vdev's path and "underlying path"
before running the command. For device mapper, multipath, or partitioned
vdevs, VDEV_UPATH is the actual underlying /dev/sd* disk. This can be useful
if the command you're running requires a /dev/sd* device.

The patch also uses /sys/block/<dev>/slaves/ to lookup the underlying device
instead of using libdevmapper. This not only removes the libdevmapper
requirement at build time, but also allows you to resolve device mapper
devices without being root. This means that UDEV_UPATH get set correctly
when running zpool status/iostat as an unprivileged user.

Example:

$ zpool status -c 'echo I am $VDEV_PATH, $VDEV_UPATH'

NAME STATE READ WRITE CKSUM
mypool ONLINE 0 0 0

  mirror-0  ONLINE       0     0     0
    mpatha  ONLINE       0     0     0  I am /dev/mapper/mpatha, /dev/sdc
    sdb     ONLINE       0     0     0  I am /dev/sdb1, /dev/sdb

Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tony Hutter <hutter2@llnl.gov>
Closes #5368

Details

Provenance
Tony Hutter <hutter2@llnl.gov>Authored on Nov 29 2016, 9:45 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Nov 29 2016, 9:45 PM
Parents
rG2f71caf2d926: Allow zfs unshare <protocol> -a
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG8720e9e7482f: Add -c to zpool iostat & status to run command (authored by Tony Hutter <hutter2@llnl.gov>).Nov 29 2016, 9:45 PM