HomeFreeBSD

Avoid computing strlen() inside loops

Description

Avoid computing strlen() inside loops

Compiling with -O0 (no proper optimizations), strlen() call
in loops for comparing the size, isn't being called/initialized
before the actual loop gets started, which causes n-numbers of
strlen() calls (as long as the string is). Keeping the length
before entering in the loop is a good idea.

On some places, even with -O2, both GCC and Clang can't
recognize this pattern, which seem to happen in an array
of char pointer.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: rilysh <nightquick@proton.me>
Closes #16584

Details

Provenance
rilysh <nightquick@proton.me>Authored on Oct 2 2024, 4:10 PM
GitHub <noreply@github.com>Committed on Oct 2 2024, 4:10 PM
Parents
rGe8cbb5952d07: Update all ABI files
Branches
Unknown
Tags
Unknown