HomeFreeBSD

pf: Stop using net_epoch to synchronize access to eth rules

Description

pf: Stop using net_epoch to synchronize access to eth rules

Commit 20c4899a8eea4 modified pf_test_eth_rule() to not acquire the
rules read lock, so pf_commit_eth() was changed to wait until the
now-inactive rules are no longer in use before freeing them. In
particular, it uses the net_epoch to schedule callbacks once the
inactive rules are no longer visible to packet processing threads.

However, since commit 812839e5aaaf4, pf_test_eth_rule() acquires the
rules read lock, so this deferred action is unneeded. This patch
reverts a portion of 20c4899a8eea4 such that we avoid using deferred
callbacks to free inactive rules.

The main motivation is performance: epoch_drain_callbacks() is quite
slow, especially on busy systems, and its use in the DIOCXBEGIN handler
in particular causes long stalls in relayd when reloading configuration.

Reviewed by: kp
MFC after: 2 weeks
Sponsored by: Klara, Inc.
Sponsored by: Modirum MDPay
Differential Revision: https://reviews.freebsd.org/D48822

(cherry picked from commit 7a66b3008693ce61957e8b2a3d99829063e1e4af)

Details

Provenance
markjAuthored on Feb 6 2025, 2:36 PM
Reviewer
kp
Differential Revision
D48822: pf: Stop using net_epoch to synchronize access to eth rules
Parents
rGfd258b6dd15b: ipfw: make 'ipfw show' output compatible with 'ipfw add' command
Branches
Unknown
Tags
Unknown