Diffusion FreeBSD src repository 847d03060f97

Fix ACL checks for NFS kernel server
847d03060f97
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Fix ACL checks for NFS kernel server

This PR changes ZFS ACL checks to evaluate
fsuid / fsgid rather than euid / egid to avoid
accidentally granting elevated permissions to
NFS clients.

Reviewed-by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Andrew Walker <awalker@ixsystems.com>
Co-authored-by: Ryan Moeller <freqlabs@FreeBSD.org>
Signed-off-by: Ryan Moeller <freqlabs@FreeBSD.org>
Closes #13221

Details

Provenance

Brian Behlendorf <behlendorf1@llnl.gov>	Authored on Mar 21 2022, 4:21 AM
GitHub <noreply@github.com>	Committed on Mar 21 2022, 4:21 AM

Parents

rG9e3619c53552: Linux 5.16 compat: restore FSR and FSAVE

Branches

Unknown

Tags

Unknown

Event Timeline

GitHub <noreply@github.com> committed rG847d03060f97: Fix ACL checks for NFS kernel server (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Mar 21 2022, 4:21 AM

Changes (12)

Path

Size

include/

os/

freebsd/

spl/

sys/

linux/

spl/

sys/

	os/	freebsd/	spl/	sys/
				sys/

	cred.h
	space_reftree.h

module/

os/

freebsd/

zfs/

linux/

spl/

zfs/

rG847d03060f97

include/os/freebsd/spl/sys/Makefile.am

Loading...

include/os/freebsd/spl/sys/cred.h

Loading...

include/os/freebsd/spl/sys/kidmap.h

Loading...

include/os/freebsd/spl/sys/sid.h

Loading...

include/os/linux/spl/sys/cred.h

Loading...

module/Makefile.bsd

Loading...

module/os/freebsd/zfs/zfs_acl.c

Loading...

module/os/freebsd/zfs/zfs_vnops_os.c

Loading...

module/os/linux/spl/spl-cred.c

Loading...

module/os/linux/zfs/policy.c

Loading...

module/os/linux/zfs/zpl_inode.c

Loading...

module/os/linux/zfs/zpl_xattr.c

Loading...