HomeFreeBSD

Use kmem_vasprintf() in log_internal()

Description

Use kmem_vasprintf() in log_internal()

An attempt to debug zfsonlinux/zfs#2781 revealed that this code could be
simplified by using kmem_asprintf(). It is not clear that switching to
kmem_asprintf() addresses zfsonlinux/zfs#2781. However, switching to
kmem_asprintf() is cleanup that simplifies debugging such that it would
become clear that this is a bug in glibc should the issue persist.

It also brings this function almost back in sync with Illumos. This
was possible due to the recently reworked kmem code which allows us
to use KM_SLEEP in the same fashion as Illumos.

Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #2791
Issue #2781

Details

Provenance
Richard Yao <ryao@gentoo.org>Authored on Oct 11 2014, 3:01 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jan 21 2015, 11:30 PM
Parents
rG3c832b8cc13b: Linux 3.12 compat: split shrinker has s_shrink
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG841c9d43c725: Use kmem_vasprintf() in log_internal() (authored by Richard Yao <ryao@gentoo.org>).Jan 21 2015, 11:30 PM