HomeFreeBSD

Add SEEK_DATA/SEEK_HOLE to lseek()/llseek()

Description

Add SEEK_DATA/SEEK_HOLE to lseek()/llseek()

The approach taken was the rework zfs_holey() as little as
possible and then just wrap the code as needed to ensure
correct locking and error handling.

Tested with xfstests 285 and 286. All tests pass except for
7-9 of 285 which try to reserve blocks first via fallocate(2)
and fail because fallocate(2) is not yet supported.

Note that the filp->f_lock spinlock did not exist prior to
Linux 2.6.30, but we avoid the need for autotools check by
virtue of the fact that SEEK_DATA/SEEK_HOLE support was not
added until Linux 3.1.

An autoconf check was added for lseek_execute() which is
currently a private function but the expectation is that it
will be exported perhaps as early as Linux 3.11.

Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #1384

Details

Provenance
Li Dongyang <dongyang.li@anu.edu.au>Authored on Jun 13 2013, 5:51 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jul 2 2013, 4:24 PM
Parents
rGcf91b2b6b2ba: Readd zfs_holey() from OpenSolaris
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG802e7b5feb01: Add SEEK_DATA/SEEK_HOLE to lseek()/llseek() (authored by Li Dongyang <dongyang.li@anu.edu.au>).Jul 2 2013, 4:24 PM