HomeFreeBSD

Hold an explicit reference on the socket for the aiotx task.

Description

Hold an explicit reference on the socket for the aiotx task.

Previously, the aiotx task relied on the aio jobs in the queue to hold
a reference on the socket. However, when the last job is completed,
there is nothing left to hold a reference to the socket buffer lock
used to check if the queue is empty. In addition, if the last job on
the queue is cancelled, the task can run with no queued jobs holding a
reference to the socket buffer lock the task uses to notice the queue
is empty.

Fix these races by holding an explicit reference on the socket when
the task is queued and dropping that reference when the task
completes.

Reviewed by: np
MFC after: 1 week
Sponsored by: Chelsio Communications
Differential Revision: https://reviews.freebsd.org/D20539

Details

Provenance
jhbAuthored on Jun 27 2019, 7:36 PM
Parents
rG2593e9dcb295: Add support for extended descriptor format to Altera mSGDMA driver.
Branches
Unknown
Tags
Unknown

Event Timeline