HomeFreeBSD

zpool_load_compat() should create strings of length ZFS_MAXPROPLEN

Description

zpool_load_compat() should create strings of length ZFS_MAXPROPLEN

Otherwise, strlcat() can overflow them.

Coverity found this.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Neal Gompa <ngompa@datto.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13866

Details

Provenance
Richard Yao <richard.yao@alumni.stonybrook.edu>Authored on Sep 12 2022, 7:54 PM
Tony Hutter <hutter2@llnl.gov>Committed on Dec 1 2022, 8:39 PM
Parents
rGab22031d7969: icp: fix all !ENDBR objtool warnings in x86 Asm code
Branches
Unknown
Tags
Unknown

Event Timeline

Tony Hutter <hutter2@llnl.gov> committed rG792825724b69: zpool_load_compat() should create strings of length ZFS_MAXPROPLEN (authored by Richard Yao <richard.yao@alumni.stonybrook.edu>).Dec 1 2022, 8:39 PM