HomeFreeBSD

Reject streams that set ->drr_payloadlen to unreasonably large values

Description

Reject streams that set ->drr_payloadlen to unreasonably large values

In the zstream code, Coverity reported:

"The argument could be controlled by an attacker, who could invoke the
function with arbitrary values (for example, a very high or negative
buffer size)."

It did not report this in the kernel. This is likely because the
userspace code stored this in an int before passing it into the
allocator, while the kernel code stored it in a uint32_t.

However, this did reveal a potentially real problem. On 32-bit systems
and systems with only 4GB of physical memory or less in general, it is
possible to pass a large enough value that the system will hang. Even
worse, on Linux systems, the kernel memory allocator is not able to
support allocations up to the maximum 4GB allocation size that this
allows.

This had already been limited in userspace to 64MB by
ZFS_SENDRECV_MAX_NVLIST, but we need a hard limit in the kernel to
protect systems. After some discussion, we settle on 256MB as a hard
upper limit. Attempting to receive a stream that requires more memory
than that will result in E2BIG being returned to user space.

Reported-by: Coverity (CID-1529836)
Reported-by: Coverity (CID-1529837)
Reported-by: Coverity (CID-1529838)
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14285

Details

Provenance
Richard Yao <richard.yao@alumni.stonybrook.edu>Authored on Jan 23 2023, 9:16 PM
GitHub <noreply@github.com>Committed on Jan 23 2023, 9:16 PM
Parents
rG69f024a56e25: Configure zed's diagnosis engine with vdev properties
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG73968defdd0f: Reject streams that set ->drr_payloadlen to unreasonably large values (authored by Richard Yao <richard.yao@alumni.stonybrook.edu>).Jan 23 2023, 9:16 PM