HomeFreeBSD

Add ashift validation when adding devices to a pool

Description

Add ashift validation when adding devices to a pool

Currently, zpool add allows users to add top-level vdevs that have
different ashifts but doing so prevents users from being able to
perform a top-level vdev removal. Often times consumers may not realize
that they have mismatched ashifts until the top-level removal fails.

This feature adds ashift validation to the zpool add command and will
fail the operation if the sector size of the specified vdev does not
match the existing pool. This behavior can be disabled by using the -f
flag. In addition, new flags have been added to provide fine-grained
control to disable specific checks. These flags
are:

--allow-in-use
--allow-ashift-mismatch
--allow-replicaton-mismatch

The force flag will disable all of these checks.

Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mark Maybee <mmaybee@delphix.com>
Signed-off-by: George Wilson <gwilson@delphix.com>
Closes #15509

Details

Provenance
George Wilson <george.wilson@delphix.com>Authored on Mar 29 2024, 7:15 PM
Tony Hutter <hutter2@llnl.gov>Committed on Apr 29 2024, 8:50 PM
Parents
rGb3b37b84e833: Fix arcstats for FreeBSD after zfetch support
Branches
Unknown
Tags
Unknown