HomeFreeBSD

iflib: invert default restart on VLAN changes

Description

iflib: invert default restart on VLAN changes

In rS360398, a new iflib device method was added to opt out of VLAN
events needing an interface reset.

I am switching the default to not requiring a restart for:

  • VLAN events
  • unknown events

After fixing various bugs, I do not think this would be a common need
of hardware and it is undesirable from the user's perspective causing
link flaps and much slower VLAN configuration. Currently, there are no
other restart events besides VLAN events, and setting the
ifdi_needs_restart default to false will alleviate the need to churn
every driver if an odd event is added in the future for specific
hardware.

markj points out this could cause churn in the other direction; I will
solve that problem with an event registration system as he mentions in
the review should we need it in the future.

These drivers will opt into restart and need further inspection or work:

  • ixv (needs code audit, 61a8231 fixed principal issue; re-init probably

not necessary)

  • axgbe (needs code audit; re-init probably not necessary)
  • iavf - (needs code audit; interaction with Malicious Driver Detection

mentioned in rS360398)

  • mgb - no VLAN functions are currently implemented. Left a comment.

Sponsored by: BBOX.io
Differential Revision: https://reviews.freebsd.org/D41558

(cherry picked from commit 725e4008efef32dfbe57b3e21635fa80dde8ee38)

Details

Provenance
Kevin Bowling <kbowling@FreeBSD.org>Authored on Aug 24 2023, 8:42 PM
Differential Revision
D41558: iflib: invert default restart on VLAN changes
Parents
rG699014f7981b: ice: Don't restart on VLAN changes
Branches
Unknown
Tags
Unknown