HomeFreeBSD

Makefile: Avoid sanitizing PATH on non-FreeBSD systems

Description

Makefile: Avoid sanitizing PATH on non-FreeBSD systems

Allow the build process to find host binaries during the host-symlinks target when
cross-building on non-FreeBSD systems. Whilst most non-FreeBSD systems have all
the needed tools in /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/bin (the final
path added by host-symlinks itself), Homebrew for macOS on Arm defaults to
/opt/homebrew/bin, other more niche systems may also deviate and users may
expect tools in a customised PATH to be picked up, unlike on FreeBSD where we
want to ensure everything comes from base. In particular, (un)xz are needed
from Homebrew on macOS, and thus cannot be found on Arm without this.

Note that non-FreeBSD builds enforce BUILD_WITH_STRICT_TMPPATH, and so the
actual main build steps will still use a sanitised PATH.

Reviewed by: jrtc27, arichardson
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D37991

(cherry picked from commit 16fbf0191243e7c9dff6615b1424b5d39186b36c)

Details

Provenance
jfreeAuthored on Jan 19 2023, 10:24 PM
jrtc27Committed on Jan 31 2023, 1:46 AM
Reviewer
jrtc27
Differential Revision
D37991: Makefile: Avoid sanitizing PATH on non-FreeBSD systems
Parents
rGfd22978f860c: strfmon(3): Match the return type
Branches
Unknown
Tags
Unknown