HomeFreeBSD

zed additional features

Description

zed additional features

This commit adds two features to zed, that macOS desires. The first
is that when you unload the kernel module, zed would enter into a
cpubusy loop calling zfs_events_next() repeatedly. We now look for
ENODEV, returned by kernel, so zed can exit gracefully.

Second feature is -I (idle) (alas -P persist was taken) is for the
deamon to;

1; if started without ZFS kernel module, stick around waiting for it.
2; if kernel module is unloaded, go back to 1.

This is due to daemons in macOS is started by launchctl, and is
expected to stick around.

Currently, the busy loop only exists when errno is ENODEV. This is
to ensure that functionality that upstream expects is not changed.
It did not care about errors before, and it still does not. (with the
exception of ENODEV).

However, it is probably better that all errors
(ERESTART notwithstanding) exits the loop, and the issues complaining
about zed taking all CPU will go away.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Jorgen Lundman <lundman@lundman.net>
Closes #10476

Details

Provenance
Jorgen Lundman <lundman@lundman.net>Authored on Jun 22 2020, 4:53 PM
GitHub <noreply@github.com>Committed on Jun 22 2020, 4:53 PM
Parents
rG42d8d1d66ac1: Remove unnecessary terminology from error-injection in ztest
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG68301ba20e0a: zed additional features (authored by Jorgen Lundman <lundman@lundman.net>).Jun 22 2020, 4:53 PM