HomeFreeBSD

Revert Fix zpl_writepage() deadlock

Description

Revert Fix zpl_writepage() deadlock

The commit, cfc9a5c88f91f7b4d606fce89505e1f404691ea5, to fix deadlocks
in zpl_writepage() relied on PF_MEMALLOC. That had the effect of
disabling the direct reclaim path on all allocations originating from
calls to this function, but it failed to address the actual cause of
those deadlocks. This led to the same deadlocks being observed with
swap on zvols, but not with swap on the loop device, which exercises
this code.

The use of PF_MEMALLOC also had the side effect of permitting
allocations to be made from ZONE_DMA in instances that did not require
it. This contributes to the possibility of panics caused by depletion
of pages from ZONE_DMA.

As such, we revert this patch in favor of a proper fix for both issues.

Signed-off-by: Richard Yao <ryao@cs.stonybrook.edu>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #726

Details

Provenance
Richard Yao <ryao@cs.stonybrook.edu>Authored on May 7 2012, 6:14 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Aug 27 2012, 7:01 PM
Parents
rGb876dac776af: Revert Fix ASSERTION(!dsl_pool_sync_context(tx->tx_pool))
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG62c4165a1bbf: Revert Fix zpl_writepage() deadlock (authored by Richard Yao <ryao@cs.stonybrook.edu>).Aug 27 2012, 7:01 PM