HomeFreeBSD

ahc(4): resolve some minor nits

Description

ahc(4): resolve some minor nits

In ahc_init(), qoutfifo is already assigned to effectively the same
value a couple lines up, except in the first assignment it uses the
proper definition; keep the more descriptive assignment.

ahc_targetcmd_offset() gets the offset wrong entirely; as per the
area of ahc_init() this diff also touches, targetcmds is laid out first
in the shared map and it's followed by the qoutfifo. As a result, we'd
generally be getting negative offsets here. We can't actually do a
partial sync anyways, so there was no consequence to getting this wrong.

Reviewed by: imp, mav

(cherry picked from commit b5e0cc2fa44f52f16fc0b9c3f1709bc0f43fe2d0)

Details

Provenance
kevansAuthored on Apr 21 2024, 3:04 AM
Parents
rG7c3092e343c3: ahc(4)/ahd(4): fix target mode on ARM
Branches
Unknown
Tags
Unknown