HomeFreeBSD

Fix check for sed --in-place

Description

Fix check for sed --in-place

The test added in commit

4313a5b4c51e ("Detect if sed supports --in-place")

doesn't work at least on my system (autoconfig-2.69).

The issue is that SED has already been found and cached before this
function is evaluated, with the result that the test is completely
skipped.

...
checking for a sed that does not truncate output... /usr/bin/sed
...
checking for sed --in-place... (cached) /usr/bin/sed

The first test is executed by libtool.m4. This looks to have been around
in libtool for at least 15 years or so, not sure why this was not
encountered at the time of the original commit.

Fix this by caching the value of the ac_inplace flag rather than the
path to SED. Also use $SED and add AC_REQUIRE to ensure that we use the
sed that was located by the standard configure test.

Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Closes #10493

Details

Provenance
Arvind Sankar <nivedita@alum.mit.edu>Authored on Jun 22 2020, 4:08 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jun 25 2020, 1:19 AM
Parents
rG9642beef2b41: Add missing third-party license files to dist
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG5ca349f95d83: Fix check for sed --in-place (authored by Arvind Sankar <nivedita@alum.mit.edu>).Jun 25 2020, 1:19 AM