HomeFreeBSD

Micro-optimize fletcher4 calculations

Description

Micro-optimize fletcher4 calculations

When processing abds, we execute 1 kfpu_begin()/kfpu_end() pair on
every page in the abd. This is wasteful and slows down checksum
performance versus what the benchmark claimed. We correct this by moving
those calls to the init and fini functions.

Also, we always check the buffer length against 0 before calling the
non-scalar checksum functions. This means that we do not need to execute
the loop condition for the first loop iteration. That allows us to
micro-optimize the checksum calculations by switching to do-while loops.

Note that we do not apply that micro-optimization to the scalar
implementation because there is no check in
fletcher_4_incremental_native()/fletcher_4_incremental_byteswap()
against 0 sized buffers being passed.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14247

Details

Provenance
Richard Yao <richard.yao@alumni.stonybrook.edu>Authored on Dec 5 2022, 7:00 PM
GitHub <noreply@github.com>Committed on Dec 5 2022, 7:00 PM
Parents
rG7b9a423076f4: FreeBSD: zfs_register_callbacks() must implement error check correctly
Branches
Unknown
Tags
Unknown