HomeFreeBSD

Add zfs_gitrev.h to the distributed sources

Description

Add zfs_gitrev.h to the distributed sources

Commit 109d2c931020 ("Move zfs_gitrev.h to build directory") stopped
distributing zfs_gitrev.h, as it is a generated file. Add it back, with
some changes in behavior.

Change the logic for gitrev as follows

  • if the source tree is a git repository, the behavior for build is unchanged. For make dist, append -dist to the git tag in the distributed version of zfs_gitrev.h.
  • otherwise, check if the source tree contains zfs_gitrev.h, and use it if so, falling back to "unknown" if it doesn't exist.
  • clean it only in make maintainer-clean, so we don't remove it from the source tree on make clean or make distclean.

This allows disted sources to track what git tag they originally came
from, with the -dist suffix indicating that the code wasn't built
directly from git and so might contain additional changes beyond the git
tag.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Eli Schwartz <eschwartz@archlinux.org>
Signed-off-by: Arvind Sankar <nivedita@alum.mit.edu>
Closes #10595

Details

Provenance
Arvind Sankar <nivedita@alum.mit.edu>Authored on Jul 19 2020, 1:24 AM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jul 22 2020, 5:00 PM
Parents
rGd32a59fe2b29: Restore scripts/make_gitrev.sh
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG59415fc9fba4: Add zfs_gitrev.h to the distributed sources (authored by Arvind Sankar <nivedita@alum.mit.edu>).Jul 22 2020, 5:00 PM