HomeFreeBSD

Add logic to try and recover an inode with an invalid mode

Description

Add logic to try and recover an inode with an invalid mode

When an inode is detected with invalid mode bits the safe thing to
do is panic the system. This indicates a problem with the contents
of a dnode and it should never be possible. This is the default
behavior.

Unfortunately, due to flaws in the system attribute (SA) implementation
(on all platforms) it was possible that ZFS could create a damaged dnode.
This was a rare issue which only impacted dnodes which used a spill
block. Normally only symlinks and files with ACLs would require a
spill block. However, if the dataset had the xattr=sa property set
and extended attributes were used this problem could occur.

As of the 0.6.4 tag the root cause of this issue has been fixed. For
pools which are exhibiting this damage the 'zfs_recover=1' module option
may be set. This will cause ZFS to interpret the dnode with invalid
mode bits as a normal file. This may allow the files to be accessed
for recovery purposes.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #3548

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Jul 13 2015, 9:51 PM
Parents
rG47a4a6fd5fa1: Support parallel build trees (VPATH builds)
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG53b1d9794efc: Add logic to try and recover an inode with an invalid mode (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Jul 17 2015, 10:33 PM