HomeFreeBSD

Fix theoretical use of uninitialized values

Description

Fix theoretical use of uninitialized values

Clang's static analyzer complains about this.

In get_configs(), if we have an invalid configuration that has no top
level vdevs, we can read a couple of uninitialized variables. Aborting
upon seeing this would break the userland tools for healthy pools, so we
instead initialize the two variables to 0 to allow the userland tools to
continue functioning for the pools with valid configurations.

In zfs_do_wait(), if no wait activities are enabled, we read an
uninitialized error variable.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #14043

Details

Provenance
Richard Yao <richard.yao@alumni.stonybrook.edu>Authored on Oct 15 2022, 10:27 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Oct 20 2022, 12:10 AM
Parents
rG219cf0f92847: Fix userland memory leak in zfs_do_send()
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG4ecd96371bcd: Fix theoretical use of uninitialized values (authored by Richard Yao <richard.yao@alumni.stonybrook.edu>).Oct 20 2022, 12:10 AM