HomeFreeBSD

Fix "allocating allocated segment" panic

Description

Fix "allocating allocated segment" panic

Gunnar Beutner did all the hard work on this one by correctly
identifying that this issue is a race between dmu_sync() and
dbuf_dirty().

Now in all cases the caller is responsible for preventing this
race by making sure the zfs_range_lock() is held when dirtying
a buffer which may be referenced in a log record. The mmap
case which relies on zfs_putpage() was not taking the range
lock. This code was accidentally dropped when the function
was rewritten for the Linux VFS.

This patch adds the required range locking to zfs_putpage().

It also adds the missing ZFS_ENTER()/ZFS_EXIT() macros which
aren't strictly required due to the VFS holding a reference.
However, this makes the code more consistent with the upsteam
code and there's no harm in being extra careful here.

Original-patch-by: Gunnar Beutner <gunnar@beutner.name>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #541

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Oct 31 2012, 5:06 PM
Parents
rGe26ade5101ba: Fix zvol+btrfs hang
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG4c837f0d9315: Fix "allocating allocated segment" panic (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Nov 10 2012, 3:01 AM