HomeFreeBSD

OpenZFS 8940 - Sending an intra-pool resumable send stream may result in EXDEV

Description

OpenZFS 8940 - Sending an intra-pool resumable send stream may result in EXDEV

Because resuming from a token requires "guid" -> "snapshot" mapping
we have to walk the whole dataset hierarchy to find the right snapshot
to send; when both source and destination exists, for an incremental
resumable stream, libzfs gets confused and picks up the wrong snapshot
to send from: this results in attempting to send

"destination@snap1 -> source@snap2"

instead of

"source@snap1 -> source@snap2"

which fails with a "Invalid cross-device link" error (EXDEV).
Fix this by adjusting the logic behind dataset traversal in
zfs_iter_children() to pick the right snapshot to send from.
Additionally update dry-run 'zfs send -t' to print its output to
stderr: this is consistent with other dry-run commands.

Patch Notes:
Reconciled differences between OpenZFS and
aee1dd4d983c64db3c3155290d48f05243e85709.

Authored by: loli10K <ezomori.nozomu@gmail.com>
Reviewed by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Approved by: Hans Rosenfeld <rosenfeld@grumpf.home-2000.org>
Ported-by: Giuseppe Di Natale <dinatale2@llnl.gov>

OpenZFS-issue: https://www.illumos.org/issues/8940
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/9f7867c206
Closes #7171

Details

Provenance
loli10K <ezomori.nozomu@gmail.com>Authored on Dec 30 2017, 11:25 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Feb 14 2018, 10:35 PM
Parents
rG9c5167d19fe0: Project Quota on ZFS
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG4411de2116bb: OpenZFS 8940 - Sending an intra-pool resumable send stream may result in EXDEV (authored by loli10K <ezomori.nozomu@gmail.com>).Feb 14 2018, 10:35 PM