HomeFreeBSD

Fix shellcheck v0.4.6 warnings

Description

Fix shellcheck v0.4.6 warnings

Resolve new warnings reported after upgrading to shellcheck
version 0.4.6. This patch contains no functional changes.

  • egrep is non-standard and deprecated. Use grep -E instead. [SC2196]
  • Check exit code directly with e.g. 'if mycmd;', not indirectly with $?. [SC2181] Suppressed.

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Giuseppe Di Natale <dinatale2@llnl.gov>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #7040

Details

Provenance
Brian Behlendorf <behlendorf1@llnl.gov>Authored on Jan 17 2018, 6:17 PM
GitHub <noreply@github.com>Committed on Jan 17 2018, 6:17 PM
Parents
rGd658b2caa957: Remove l2arc_nocompress from zfs-module-parameters(5)
Branches
Unknown
Tags
Unknown

Event Timeline

GitHub <noreply@github.com> committed rG3da3488e6339: Fix shellcheck v0.4.6 warnings (authored by Brian Behlendorf <behlendorf1@llnl.gov>).Jan 17 2018, 6:17 PM