HomeFreeBSD

OpenZFS 7743 - per-vdev-zaps init path for upgrade

Description

OpenZFS 7743 - per-vdev-zaps init path for upgrade

Authored by: Paul Dagnelie <pcd@delphix.com>
Reviewed by: Matt Ahrens <mahrens@delphix.com>
Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com>
Reviewed by: George Wilson <george.wilson@delphix.com>
Reviewed by: Don Brady <don.brady@intel.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Joe Stein <jas14@cs.brown.edu>
Ported-by: Don Brady <don.brady@intel.com>

When loading a pool that had been created before the existance of
per-vdev zaps, on a system that knows about per-vdev zaps, the
per-vdev zaps will not be allocated and initialized.

This appears to be because the logic that would have done so, in
spa_sync_config_object(), is not reached under normal operation. It is
only reached if spa_config_dirty_list is non-empty.

The fix is to add another AVZ_ACTION_ enum that will allow this code
to be reached when we detect that we're loading an old pool, even when
there are no dirty configs.

OpenZFS-issue: https://www.illumos.org/issues/7743
OpenZFS-commit: https://github.com/openzfs/openzfs/commit/e2d29d0
Closes #5582

Details

Provenance
Don Brady <don.brady@intel.com>Authored on Jan 13 2017, 9:50 PM
Brian Behlendorf <behlendorf1@llnl.gov>Committed on Jan 13 2017, 9:50 PM
Parents
rGfdbaf44ffbff: OpenZFS 7276 - zfs(1m) manpage could better describe space properties
Branches
Unknown
Tags
Unknown

Event Timeline

Brian Behlendorf <behlendorf1@llnl.gov> committed rG38640550f28c: OpenZFS 7743 - per-vdev-zaps init path for upgrade (authored by Don Brady <don.brady@intel.com>).Jan 13 2017, 9:50 PM